add ability to define composer update channel #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since Composer 1.10.2 today, --1 and --2 are also possible channel names. |
|
as far as i can see there are some changed lines which contain only whitespace changes. can you please ensure that there are only clean diffs of lines you really changed. this helps with the review. |
bastelfreak
reviewed
Apr 10, 2020
bastelfreak
added
enhancement
|
Tests are working now except https://travis-ci.org/github/voxpupuli/puppet-php/jobs/673719739 and https://travis-ci.org/github/voxpupuli/puppet-php/jobs/673719740 which are not related to this PR. |
|
@CyberLine please rebase after #513 got merged |
bastelfreak
reviewed
Apr 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Yesterday, composer released 2.0 snapshot.
So with current default behaviour, if i only set
class { '::php::composer': max_age => 2, }every composer installation is updated to version 2.0 snapshot.
So one solution is to set the 'source' to 'https://getcomposer.org/composer-stable.phar' initialy if i dont have it installed or use the param from this PR for updates, which then defaults update channel to 'stable'